Repository navigation
Conversation
Add the numpad block of the US keyboard layout (NumpadDecimal reports Delete, Shift+numpad digits type digits with the numpad key codes) and send isKeypad on Chromium keyup so keyup reports the numpad location. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our US keyboard layout only knew NumpadEnter and NumpadSubtract, so pressing any other numpad key threw "Unknown key". It now has the full numpad block from upstream. Numpad digits and NumpadDecimal act as navigation keys (NumpadDecimal reports
Delete). With Shift held they type the digit or.with the numpad key code. Chromium keyup now sendsisKeypadtoo, so keyup reports the numpad location like keydown does. The Alt-modifier test needed no library change: we already drop text when a non-Shift modifier is held.Closes #20
🤖 Generated with Claude Code