-
-
Notifications
You must be signed in to change notification settings - Fork 845
Updated Instructions for img Tag Markup Style in HfLA Contributing Guide (CONTRIBUTING.md) #8471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Updated Instructions for img Tag Markup Style in HfLA Contributing Guide (CONTRIBUTING.md) #8471
Conversation
The markdown template for pull requests instructed users to use self-closing style HTML5 IMG tag (i.e. <img/>) for large images. With this change users will be instructed to use standard HTML5 IMG tag (i.e. <img>).
|
Want to review this pull request? Take a look at this documentation for a step by step guide! Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
|
Review ETA: 9 PM 1/24/26 |
ldaws003
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @abinetabate1 . The requested change was made and it shows in the branches for the merge are also right. Also, good touch in uploading the screenshots of the preview of the CONTRIBUTING.md file.
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work.
Just check off the action items in the GitHub issue.
Thanks |
Thanks. Action items have been checked off. |
Fixes #7797
What changes did you make?
Why did you make the changes (we will use this info to test)?
For Reviewers: Do not test changes locally, rather test changes at: https://github.com/abinetabate1/website/blob/img-tag-refactor-contributing-md-7797/CONTRIBUTING.md
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied