fix: improve database health check error reporting and correctness [Backport release/0.5.z]

[trustify-ci-bot]

Description

Backport of #2416 to release/0.5.z.

Summary by Sourcery

Improve reliability and observability of local health checks and keep health monitoring active when the infrastructure endpoint is disabled.

Bug Fixes:

• Ensure the database health check reports failure if the check future terminates unexpectedly instead of silently succeeding.
• Prevent health checks from being dropped when the infrastructure endpoint is disabled by keeping the health subsystem alive.
• Avoid panics in the database health check by treating errors from the local check setup as a failed check instead of unwrapping the result.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Backport that improves health check error propagation, logging, and lifetime management so database health checks remain accurate and retained even when the infrastructure endpoint is disabled.

File-Level Changes

Change	Details	Files
Preserve and propagate health check error messages across threads and improve logging when a health check future terminates.	Convert the incoming error into a Cow<'static, str> once and reuse it instead of re-converting later Clone the error into the spawned thread so it can be logged when the health check future returns Change the log message when the check future ends to a warning that includes the error message Store the pre-converted error directly in the Local struct instead of calling into() again	common/infrastructure/src/health/checks/local.rs
Keep health checks alive even when the infrastructure endpoint is disabled.	When infrastructure is disabled, keep a reference to self.health inside an infinite sleep loop to prevent registered health checks from being dropped while the server runs	common/infrastructure/src/infra.rs
Make the database health check treat failures to schedule the check as a failed health state instead of a success.	Replace is_ok() on the result of registering the health check with unwrap_or(false) so errors in spawning or running the health check yield a failing status instead of passing	server/src/profile/mod.rs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In spawn_db_check, now that unwrap_or(false) maps any error to a failed check, consider logging the underlying error before returning false so that failures during check registration/setup are observable.
• In Infrastructure::run when the endpoint is disabled, the infinite loop using sleep(Duration::from_secs(3600)) would be clearer and easier to tune if the sleep interval were extracted into a named constant.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `spawn_db_check`, now that `unwrap_or(false)` maps any error to a failed check, consider logging the underlying error before returning `false` so that failures during check registration/setup are observable.
- In `Infrastructure::run` when the endpoint is disabled, the infinite loop using `sleep(Duration::from_secs(3600))` would be clearer and easier to tune if the sleep interval were extracted into a named constant.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}