netty: Increase HPACK encoder bucket count to 128 - #13077
Open
petedmarsh wants to merge 1 commit into
Open
petedmarsh wants to merge 1 commit into
petedmarsh wants to merge 1 commit into
Conversation
| Http2FrameReader frameReader = new DefaultHttp2FrameReader(headersDecoder); | ||
| Http2HeadersEncoder encoder = new DefaultHttp2HeadersEncoder( | ||
| sensitivityDetector(neverIndexedMetadataKeys), false, 16, Integer.MAX_VALUE); | ||
| sensitivityDetector(neverIndexedMetadataKeys), false, 128, Integer.MAX_VALUE); |
Contributor
There was a problem hiding this comment.
Can we add a TODO to upstream changes to Netty before we can migrate to the Http2FrameCodecBuilder API that does not allow injecting a custom Http2HeadersEncoder subclass?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase the HPACK encoder bucket count from 16 to 128 for both clients and servers. Netty 4.1.138/4.2.18 limits encoder tables to
bucket count × 64when processing a peer's table-size setting, so this allows up to 8 KiB within the peer's advertised limit. Advertised table sizes and the Netty dependency version are unchanged.Separate JMH benchmark and results: at the same 4 KiB capacity, 128 buckets reduced synthetic mixed-header processing time by 24–28%, with unchanged per-request allocation and encoded size. Encoder construction allocated an additional 896 bytes with compressed references.
Related to #12973. Discovered by @ejona86.