xds: honor requested_server_name from TLS SNI#12771
Open
1seal wants to merge 1 commit intogrpc:masterfrom
Open
xds: honor requested_server_name from TLS SNI#127711seal wants to merge 1 commit intogrpc:masterfrom
1seal wants to merge 1 commit intogrpc:masterfrom
Conversation
|
|
Contributor
|
You need to sign the Easy CLA before being able to contribute. Also is the PR still to undergo changes since it is in Draft state? |
1seal
force-pushed
the
codex/rbac-sni-requested-server-name
branch
from
14f3c7c to
782b981
Compare
Author
|
thanks for the reminder. EasyCLA is now green for @1seal. i fixed the xDS checkstyle import-order issue that was causing the Linux test shards to fail, re-ran the focused checks locally, and moved the PR out of Draft. local validation:
no functional changes are currently planned; i’ll follow up if the refreshed CI shows anything else. |
Read requested_server_name from the TLS SNI on ExtendedSSLSession so RBAC policies can match the value Envoy config provides. Add a regression test covering a deny policy that depends on the requested server name.
1seal
force-pushed
the
codex/rbac-sni-requested-server-name
branch
from
782b981 to
91637e5
Compare
Author
|
follow-up: the refreshed GitHub Actions and Codecov checks are green on the latest head. the only remaining check i see is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
requested_server_namefrom the TLS SNI exposed byExtendedSSLSessionwhy
RequestedServerNameMatcherwas wired through the xDS RBAC engine, butGrpcAuthorizationEnginealways returned an empty string forrequested_server_name. That made policies depending on this field ineffective and could allow traffic that should have matched a deny policy.impact
xDS RBAC policies that use
requested_server_namenow evaluate against the SNI the client presented during the TLS handshake instead of always seeing an empty value.validation
./gradlew --no-daemon --console=plain --info -PskipAndroid=true -PskipCodegen=true :grpc-xds:test --tests 'io.grpc.xds.internal.rbac.engine.GrpcAuthorizationEngineTest.requestedServerNameMatcher_matchesTlsSni'