Repository navigation
fix(grafana): move or remove the last 6 UI-made alert rules (#1690) - #1694
Merged
Merged
Conversation
- heat pump overload webhook-lA5nSTt4k: per-phase mean > 1000 W over 15 min, for 15m (the meaning of UI rule xjXziW_4k); the old max over all phases > 3000 W could never fire - move External/Output alert (heatpump-ctrl) and controlbox temperature/humidity alerts into provisioned rules with the same query, threshold and for; messages match the thresholds - delete the 6 UI rules through deleteRules
Owner
Author
Review and local testLocal Grafana 9.5.21 + InfluxDB 1.12.4 (rule interval 10s and
Subagent review: no blockers. It checked each moved rule field by field against the Grafana DB export. Fixed: the overload message now says plainly that the limit is per phase. Kept as before: the overload rule keeps Before deploy I check again that all 6 UI rules and |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1690.
Owner decision from #1690: remove 2 UI-made rules that a provisioned rule covers, and move 4 into the repo. After this, folder "General Alerting" has no UI-made rules.
Heat pump overload: the provisioned rule did not cover the UI rule
The issue asked to confirm this before deleting
xjXziW_4k. It did not match:xjXziW_4kwebhook-lA5nSTt4k(before)mean(p)ofcurrent_power,heat_pump, grouped by phasemax(p), all phases in one seriesSo the provisioned rule needed one phase above 3000 W. Data on routy:
Decision (option A, agreed):
webhook-lA5nSTt4know has the UI rule's meaning: per-phase mean > 1000 W over 15 min, for 15m. The message says "над 1000 W на поне една фаза ... (3 x 1000 W = 3000 W общо)". ThenxjXziW_4kis deleted.Other rules
3057STtVkzAC alert (210/248 V, no for)webhook-3057STtVkz(207/253 V, 4m) staysRJcnSop4zExternal alertwebhook-RJcnSop4zinheat-pump-alerts.yaml:min(s2Temp)ofmonitoring2heatpump-ctrl, avg < 5 °C, for 5meAc7ITtVkOutput alertwebhook-eAc7ITtVk:max(s3Temp), avg > 60 °C, for 5mrA5nSotVkzTemperature alertwebhook-rA5nSotVkzin newcontrolbox-alerts.yaml:mean(t)ofxymd1controlbox(t < 80), outside 5-37 °C, for 5m. The message now says 5-37 (it said 5-35).j05nSotVzHumidity alertwebhook-j05nSotVz:mean(h), outside 15-85 %, for 5mThe 4 moved rules use the exact query, reducer, window and
forread from the Grafana DB copy.noDataStateandexecErrStatestayOKas in the UI rules, so a short InfluxDB restart does not page (#1682). Deletes go throughdeleteRulesindelete-legacy-duplicate-alerts.yaml, like #1683.Deploy without a page
On routy at 15:04 UTC, all 6 UI rules and
webhook-lA5nSTt4kare Normal, so the new copies start Normal and do not page.Tests
validate-grafana-alerts: passes for the 3 changed files.