Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…add_sign_flip_for_nedelec_hexa_facet_dofs
This reverts commit e1d5547.
There was a problem hiding this comment.
Pull request overview
Updates GridapDistributed’s div/curl-conforming FE space construction to also handle Nedelec elements (needed for correct orientation/sign behavior, especially for HEX/Nedelec), and extends the corresponding tests/changelog.
Changes:
- Generalize distributed
FESpaceconstructors from Raviart–Thomas-only to Raviart–Thomas and Nedelec. - Update/expand tests to exercise the new Nedelec paths and align module naming/includes.
- Add an Unreleased NEWS entry and introduce a root
Manifest.toml(currently problematic given repo conventions).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/sequential/DivAndCurlConformingTests.jl | Switches sequential wrapper to include/run the renamed div+curl test module. |
| test/DivAndCurlConformingTests.jl | Renames the module and adds Nedelec test cases (currently 2D/QUAD only). |
| src/GridapDistributed.jl | Fixes the include to load DivAndCurlConformingFESpaces.jl. |
| src/DivAndCurlConformingFESpaces.jl | Broadens distributed FESpace overloads to accept Nedelec in addition to Raviart–Thomas. |
| NEWS.md | Adds an Unreleased bullet describing the Nedelec HEX-related changes. |
| Manifest.toml | Adds a pinned, machine-generated manifest (conflicts with .gitignore policy). |
Comments suppressed due to low confidence (2)
test/sequential/DivAndCurlConformingTests.jl:6
- This sequential wrapper’s module name (
DivConformingTestsSeq) no longer matches the included test module (DivAndCurlConformingTests) and the file’s intent. Renaming the wrapper module (and ensuringtest/sequential/runtests.jlincludes the correct wrapper filename) will avoid confusion and prevents the new tests from being skipped due to stale include paths.
test/DivAndCurlConformingTests.jl:145 - The newly added Nedelec coverage here only exercises 2D QUAD elements, but the PR is about HEX Nedelec orientation/sign behavior. Please add at least one minimal 3D/HEX test case (ideally on a non-Cartesian/unstructured hexa mesh) to ensure the intended regression is actually covered.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #198 +/- ##
=======================================
Coverage 85.11% 85.11%
=======================================
Files 16 16
Lines 4254 4254
=======================================
Hits 3621 3621
Misses 633 633
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR can be already merged once the tests pass.