Skip to content

Sign flip for HEX Nedelec FEs#198

Merged
amartinhuertas merged 6 commits intomasterfrom
add_sign_flip_for_nedelec_hexa_facet_dofs
Mar 14, 2026
Merged

Sign flip for HEX Nedelec FEs#198
amartinhuertas merged 6 commits intomasterfrom
add_sign_flip_for_nedelec_hexa_facet_dofs

Conversation

@amartinhuertas
Copy link
Member

@amartinhuertas amartinhuertas commented Mar 13, 2026

This PR can be already merged once the tests pass.

@amartinhuertas amartinhuertas requested a review from Copilot March 13, 2026 06:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GridapDistributed’s div/curl-conforming FE space construction to also handle Nedelec elements (needed for correct orientation/sign behavior, especially for HEX/Nedelec), and extends the corresponding tests/changelog.

Changes:

  • Generalize distributed FESpace constructors from Raviart–Thomas-only to Raviart–Thomas and Nedelec.
  • Update/expand tests to exercise the new Nedelec paths and align module naming/includes.
  • Add an Unreleased NEWS entry and introduce a root Manifest.toml (currently problematic given repo conventions).

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/sequential/DivAndCurlConformingTests.jl Switches sequential wrapper to include/run the renamed div+curl test module.
test/DivAndCurlConformingTests.jl Renames the module and adds Nedelec test cases (currently 2D/QUAD only).
src/GridapDistributed.jl Fixes the include to load DivAndCurlConformingFESpaces.jl.
src/DivAndCurlConformingFESpaces.jl Broadens distributed FESpace overloads to accept Nedelec in addition to Raviart–Thomas.
NEWS.md Adds an Unreleased bullet describing the Nedelec HEX-related changes.
Manifest.toml Adds a pinned, machine-generated manifest (conflicts with .gitignore policy).
Comments suppressed due to low confidence (2)

test/sequential/DivAndCurlConformingTests.jl:6

  • This sequential wrapper’s module name (DivConformingTestsSeq) no longer matches the included test module (DivAndCurlConformingTests) and the file’s intent. Renaming the wrapper module (and ensuring test/sequential/runtests.jl includes the correct wrapper filename) will avoid confusion and prevents the new tests from being skipped due to stale include paths.
    test/DivAndCurlConformingTests.jl:145
  • The newly added Nedelec coverage here only exercises 2D QUAD elements, but the PR is about HEX Nedelec orientation/sign behavior. Please add at least one minimal 3D/HEX test case (ideally on a non-Cartesian/unstructured hexa mesh) to ensure the intended regression is actually covered.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.11%. Comparing base (e1d5547) to head (872c537).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   85.11%   85.11%           
=======================================
  Files          16       16           
  Lines        4254     4254           
=======================================
  Hits         3621     3621           
  Misses        633      633           
Flag Coverage Δ
mpi-adaptivity 45.45% <ø> (ø)
mpi-fespaces 39.99% <ø> (ø)
mpi-geometry 23.26% <ø> (ø)
mpi-misc 50.18% <ø> (ø)
mpi-physics 35.56% <ø> (ø)
mpi-transient 24.78% <ø> (ø)
seq-adaptivity 39.38% <ø> (ø)
seq-fespaces 40.41% <ø> (ø)
seq-geometry 23.30% <ø> (ø)
seq-misc 34.91% <ø> (ø)
seq-physics 36.63% <ø> (ø)
seq-transient 24.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amartinhuertas amartinhuertas marked this pull request as ready for review March 14, 2026 05:54
@amartinhuertas amartinhuertas merged commit ee04cc6 into master Mar 14, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants