Fix spread style attributes in GCI26 and GCI29 rules#101
Merged
Conversation
utarwyn
changed the title
utarwyn
changed the title
utarwyn
changed the title
utarwyn
force-pushed
the
issue-100-fix-spread-props
branch
from
1ddfcd6 to
566297a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #100
When a JSX element contains spread elements inside a
styleattribute (e.g.style={{ ...someProps.style, color: 'red' }}), the rules would crash with:This happened because spread elements (
SpreadElementnodes) have nokeyproperty, so accessingprop.key.namethrew when iterating overproperties.Changes
prefer-shorthand-css-notations(GCI26)avoid-css-animations(GCI29)Testing
All 152 tests pass: