declare type definitions on EventBus#75
Open
e-pavlica wants to merge 1 commit into
Open
Conversation
To address graphiti-api#54, adjusts the EventBus import to preserve the imported name, while still adding type definitions to the imported object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address #54, adjusts the EventBus import to preserve the imported name, while still adding type definitions to the imported object.
I think the behavior described in #54 has to do with some sort of proxying Rollup/tsc is doing; reassigning the name of the imported object seems to break accessing the properties of said object. By maintaining the
EventBusname across the import/export, the referenced bug no longer occurs.I'm by no means a TS expert, so this may be completely off base, but it does allow us to use
ApplicationRecord.sync = truein my current project.