test(cypher): harden two-MATCH reentry varlen regression coverage (#1001)#1329
Merged
test(cypher): harden two-MATCH reentry varlen regression coverage (#1001)#1329
Conversation
This was referenced May 7, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens coverage around
#1001(two-MATCH reentry + varlen wrong-row concern) by moving from permissive shape checks to exact-result and equivalence assertions.What changed
result._nodes is not NoneWhy
Issue
#1001reported wrong rows for TCK-style queriesmatch5-25/26. Currentmasterbehavior was not reproducible as a product wrong-row bug on valid standalone fixtures; this PR locks that behavior with explicit tests to prevent regressions.Validation
PYTHONPATH=. UV_CACHE_DIR=/tmp/uv-cache uv run --no-project --with pytest --with pandas python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "nonterminal_variable_length_relationship_patterns or two_match_reentry_varlen"PYTHONPATH=. UV_CACHE_DIR=/tmp/uv-cache uv run --no-project --with pytest --with pandas python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "reentry"./bin/ruff.sh graphistry/tests/compute/gfql/cypher/test_lowering.pyRefs #1001