Phase 1: #1219 row-boolean WHERE audit + TCK-linked tests#1223
Merged
Phase 1: #1219 row-boolean WHERE audit + TCK-linked tests#1223
Conversation
This was referenced Apr 26, 2026
lmeyerov
commented
Apr 26, 2026
lmeyerov
added a commit
that referenced
this pull request
Apr 27, 2026
lmeyerov
added a commit
that referenced
this pull request
Apr 27, 2026
lmeyerov
force-pushed
the
issue-1219-phase1-audit
branch
from
8fa7324 to
eff2a84
Compare
lmeyerov
added a commit
that referenced
this pull request
Apr 27, 2026
lmeyerov
force-pushed
the
issue-1219-phase1-audit
branch
from
f9fc71d to
c8bbe38
Compare
lmeyerov
added a commit
that referenced
this pull request
Apr 27, 2026
lmeyerov
force-pushed
the
issue-1219-phase1-audit
branch
from
c8bbe38 to
2c6d590
Compare
lmeyerov
commented
Apr 27, 2026
| emit gfql '^graphistry/gfql/|^graphistry/compute/gfql/|^graphistry/compute/gfql_unified\.py$|^graphistry/models/gfql/|^graphistry/Plottable\.py$|^tests/gfql/' | ||
| emit cypher_frontend_ci '^\.github/workflows/ci\.yml$|^\.github/workflows/ci-gpu\.yml$|^graphistry/compute/gfql/ir/|^graphistry/compute/gfql/cypher/|^graphistry/compute/gfql/frontends/cypher/|^graphistry/tests/compute/gfql/cypher/|^tests/gfql/ref/' | ||
| emit benchmarks '^benchmarks/' | ||
| emit docs '^docs/|\.md$|\.rst$|^demos/|^notebooks/' |
Contributor
Author
There was a problem hiding this comment.
bad rebase, lost syntax cleanups
lmeyerov
commented
Apr 27, 2026
| --jq "[.[] | select(.draft|not) | select(.prerelease|not)][0].tag_name") | ||
| fi | ||
| if [ -z "${tag}" ] || [ "${tag}" = "null" ]; then | ||
| echo "::error::Unable to resolve any stable actionlint release" |
Contributor
Author
There was a problem hiding this comment.
likely bad rebase too
lmeyerov
commented
Apr 27, 2026
| where_out.append( | ||
| compare( | ||
| col(predicate.left.alias, predicate.left.property), | ||
| col(cast(PropertyRef, predicate.left).alias, cast(PropertyRef, predicate.left).property), |
lmeyerov
added a commit
that referenced
this pull request
Apr 27, 2026
lmeyerov
added a commit
that referenced
this pull request
Apr 27, 2026
lmeyerov
force-pushed
the
issue-1219-phase1-audit
branch
from
2eb6cef to
753dec7
Compare
lmeyerov
added a commit
that referenced
this pull request
Apr 27, 2026
lmeyerov
force-pushed
the
issue-1219-phase1-audit
branch
from
8e5a6e5 to
e7c0f6a
Compare
Base automatically changed from
issue-1031-grammar-mixed-where-pattern-expr
to
master
April 27, 2026 23:57
lmeyerov
force-pushed
the
issue-1219-phase1-audit
branch
from
e7c0f6a to
46fc89a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of #1219 stack: test/audit hardening only (no behavior expansion).
Adds a focused row-boolean WHERE matrix for:
Why
#1217(Earley parser) broadens accepted row-boolean shapes. This PR captures current support boundaries with explicit positive/negative coverage and TCK-linked IDs where applicable, so Phase 2 can expand behavior against a fixed audit baseline.Scope
graphistry/tests/compute/gfql/cypher/test_lowering.pytest_issue_1219_row_boolean_audit_*matrix testsValidation
Ran:
./bin/pytest.sh graphistry/tests/compute/gfql/cypher/test_lowering.py -k "issue_1219_row_boolean_audit" -qResult: 9 passed.
Stack
issue-1031-grammar-mixed-where-pattern-expr)Refs #1219