Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions diskcache/persistent.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ def maxlen(self, value):
self._popleft()

def _index(self, index, func):
index = op.index(index)
len_self = len(self)

if index >= 0:
Expand Down
28 changes: 28 additions & 0 deletions tests/test_deque.py
Original file line number Diff line number Diff line change
Expand Up @@ -312,3 +312,31 @@ def test_peek(deque):
assert len(deque) == 1
assert deque.peek() == value
assert len(deque) == 1


@pytest.mark.parametrize('index', [0.0, 1.0])
@pytest.mark.parametrize('operation', ['get', 'set', 'del'])
def test_index_rejects_float_without_mutation(deque, index, operation):
deque.extend('abc')
method = getattr(deque, '__' + operation + 'item__')
args = (index, 'changed') if operation == 'set' else (index,)
with pytest.raises(TypeError):
method(*args)
assert list(deque) == list('abc')


def test_index_protocol(deque):
class Index:
def __init__(self, value):
self.value = value

def __index__(self):
return self.value

deque.extend('abc')
assert deque[Index(1)] == 'b'
deque[Index(-1)] = 'z'
del deque[Index(0)]
assert list(deque) == ['b', 'z']
with pytest.raises(IndexError):
deque[Index(2)]