You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Validate sampling operations on unaligned block-compressed textures. - #4717
I finally got some time to look into this. The CTS already had all the machinery needed to test these edge cases, so this is a single new test in textureSampleLevel.spec.ts.
One concern that I have, though, is that checkCallResults uses a softwareTexture that come from createTextureWithRandomDataAndGetTexels and is initialized by reading the compressed texture back using textureLoad to sample every texel. The JS implements filtering and address modes, but not block decoding.
A decode bug that affected textureLoad and textureSampleLevel identically on partial blocks would not be caught. Implementing a software decoder for every block compression format is out of scope for this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue: #4707
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off: