Skip to content

Fix configure:invalid_usage for bgra8unorm storage - #4716

Merged
sudonatalie merged 2 commits into
gpuweb:mainfrom
sudonatalie:bgra8unorm-storage
Oct 7, 2026
Merged

sudonatalie merged 2 commits into
gpuweb:mainfrom
sudonatalie:bgra8unorm-storage

Conversation

@sudonatalie

Copy link
Copy Markdown
Contributor

bgra8unorm with STORAGE_BINDING is a validation error unless "bgra8unorm-storage" is enabled. Update the test to check this condition.

Spec: https://gpuweb.github.io/gpuweb/#bgra8unorm-storage

Chrome bug: https://crbug.com/565366976


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

bgra8unorm with STORAGE_BINDING is a validation error unless
"bgra8unorm-storage" is enabled. Update the test to check this
condition.

Spec: https://gpuweb.github.io/gpuweb/#bgra8unorm-storage

Chrome bug: https://crbug.com/565366976
@sudonatalie
sudonatalie requested a review from kainino0x October 6, 2026 19:54
@sudonatalie

Copy link
Copy Markdown
Contributor Author

I haven't actually tested that this test now passes on an android device. If I can validate with @s-perron's new runner tomorrow I'll try that.

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Results for build job (at e825e04):

 Test case/subcase counts did not change.

@sudonatalie

Copy link
Copy Markdown
Contributor Author

Since this needs a canvas and can't be run with the node runner, it's proving to be pretty cumbersome to validate. Verified it skips (though not for the right reason) and will monitor on CQ to see that it resolves the expected expectation.

@sudonatalie
sudonatalie enabled auto-merge (squash) October 7, 2026 15:40
@sudonatalie
sudonatalie merged commit cc11994 into gpuweb:main Oct 7, 2026
1 check passed
@sudonatalie
sudonatalie deleted the bgra8unorm-storage branch October 7, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants