Repository navigation
Fix configure:invalid_usage for bgra8unorm storage - #4716
Merged
Merged
Conversation
bgra8unorm with STORAGE_BINDING is a validation error unless "bgra8unorm-storage" is enabled. Update the test to check this condition. Spec: https://gpuweb.github.io/gpuweb/#bgra8unorm-storage Chrome bug: https://crbug.com/565366976
Contributor
Author
|
I haven't actually tested that this test now passes on an android device. If I can validate with @s-perron's new runner tomorrow I'll try that. |
kainino0x
approved these changes
Oct 7, 2026
Contributor
Author
|
Since this needs a canvas and can't be run with the node runner, it's proving to be pretty cumbersome to validate. Verified it skips (though not for the right reason) and will monitor on CQ to see that it resolves the expected expectation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bgra8unorm with STORAGE_BINDING is a validation error unless "bgra8unorm-storage" is enabled. Update the test to check this condition.
Spec: https://gpuweb.github.io/gpuweb/#bgra8unorm-storage
Chrome bug: https://crbug.com/565366976
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.