Skip to content

chore: Rerouted legacy client row filters to data client row filters. #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gkevinzheng wants to merge 2 commits into
base: v3_staging
Choose a base branch
from
Open

chore: Rerouted legacy client row filters to data client row filters. #1255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41dcace
chore: Rerouted legacy client row filters to data client row filters.
gkevinzheng Jan 7, 2026
f6b90f7
Changed attribute mapping + moved ABC classes to test file + changed
gkevinzheng Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/bigtable/row.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def _delete_cells(self, column_family_id, columns, time_range=None, state=None):
else:
delete_kwargs = {}
if time_range is not None:
delete_kwargs["time_range"] = time_range.to_pb()
delete_kwargs["time_range"] = time_range._to_pb()

to_append = []
for column in columns:
Expand Down Expand Up @@ -601,7 +601,7 @@ def commit(self):
resp = data_client.check_and_mutate_row(
table_name=self._table.name,
row_key=self._row_key,
predicate_filter=self._filter.to_pb(),
predicate_filter=self._filter._to_pb(),
app_profile_id=self._table._app_profile_id,
true_mutations=true_mutations,
false_mutations=false_mutations,
Expand Down
Loading
Loading