fix: use the same background executor in otel reader and monitoring c… #2746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
...ain/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableCloudMonitoringExporter.java
Show resolved
Hide resolved
...igtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsView.java
Show resolved
Hide resolved
igorbernstein2
previously approved these changes
Dec 23, 2025
Contributor
igorbernstein2
left a comment
igorbernstein2
left a comment
There was a problem hiding this comment.
lgtm after comments are addressed
| // if the background executor in the settings is already a FixedExecutorProvider, | ||
| // we can't assume that we can autoclose it and the life cycle should be managed | ||
| // by the application | ||
| canAutoCloseExecutor = false; |
Contributor
There was a problem hiding this comment.
Can we create our own implementation of the ExecutorProvider with a settable bit for shouldAutoClose and use that instead of the FixedExecutorProvider? This way we can localize the lifecycle management instead of messing around with background resources?
But still passing a FixedExecutorProvider to the child clients like metrics?
igorbernstein2
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lient
Use the same background executor in monitoring client and OpenTelemetry Periodic readers as the bigtable client. This executor is only used for background tasks, so monitoring client is still gonna have different executors for its channels.
Since we convert the background executor to a fixed executor provider, we need to add it back to the background resources to auto close it.