Skip to content

cleanup(pubsub): no AckResult alias#4981

Merged
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:cleanup-pubsub-ack-result-begone
Mar 11, 2026
Merged

cleanup(pubsub): no AckResult alias#4981
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:cleanup-pubsub-ack-result-begone

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Mar 10, 2026

Part of the work for #4508

Remove a less-than-helpful alias.

Not a break, because this hasn't been released.

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Mar 10, 2026
@dbolduc dbolduc marked this pull request as ready for review March 11, 2026 01:41
@dbolduc dbolduc requested a review from a team as a code owner March 11, 2026 01:41
@dbolduc dbolduc enabled auto-merge (squash) March 11, 2026 01:41
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.05%. Comparing base (0fc24aa) to head (7d3972f).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4981      +/-   ##
==========================================
- Coverage   93.06%   93.05%   -0.02%     
==========================================
  Files         221      221              
  Lines        8611     8611              
==========================================
- Hits         8014     8013       -1     
- Misses        597      598       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc merged commit 3b3e731 into googleapis:main Mar 11, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants