Skip to content

cleanup(pubsub): future-proof AckError#4979

Merged
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:cleanup-pubsub-future-proof-ack-error
Mar 10, 2026
Merged

cleanup(pubsub): future-proof AckError#4979
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:cleanup-pubsub-future-proof-ack-error

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Mar 10, 2026

Fixes #4809, related to #4508

We discussed whether the RPC branch should parse the string the server returns into an enum. My official stance on the matter is "why....".

We remove the details field for now, and mark the branch as non-exhaustive.

Non breaking, because AckError was never released.

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Mar 10, 2026
@dbolduc dbolduc marked this pull request as ready for review March 10, 2026 20:19
@dbolduc dbolduc requested a review from a team as a code owner March 10, 2026 20:19
@dbolduc dbolduc merged commit 1a6f6e4 into googleapis:main Mar 10, 2026
35 checks passed
@dbolduc dbolduc deleted the cleanup-pubsub-future-proof-ack-error branch March 10, 2026 22:05
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.09%. Comparing base (0fc24aa) to head (ed6c8f0).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4979      +/-   ##
==========================================
+ Coverage   93.06%   93.09%   +0.02%     
==========================================
  Files         221      221              
  Lines        8611     8611              
==========================================
+ Hits         8014     8016       +2     
+ Misses        597      595       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stabilize AckError

2 participants