Skip to content

test(spanner): await database calls in async snippets #17627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sakthivelmanii wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(spanner): await database calls in async snippets #17627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/google-cloud-spanner/samples/samples/async_snippets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ async def async_create_client(instance_id, database_id):
"""Instantiates an asynchronous Spanner client."""
spanner_client = AsyncClient()
instance = spanner_client.instance(instance_id)
database = instance.database(database_id)
database = await instance.database(database_id)

print("Async Spanner client instantiated successfully.")
return database
Expand All @@ -40,7 +40,7 @@ async def async_query_data(instance_id, database_id):
"""Queries sample data from the database using asynchronous SQL."""
spanner_client = AsyncClient()
instance = spanner_client.instance(instance_id)
database = instance.database(database_id)
database = await instance.database(database_id)

async with database.snapshot() as snapshot:
results = await snapshot.execute_sql(
Expand All @@ -59,7 +59,7 @@ async def async_insert_data(instance_id, database_id):
"""Inserts sample data into the database using DML asynchronously."""
spanner_client = AsyncClient()
instance = spanner_client.instance(instance_id)
database = instance.database(database_id)
database = await instance.database(database_id)

async def insert_singers(transaction):
dml = (
Expand All @@ -81,7 +81,7 @@ async def async_read_write_transaction(instance_id, database_id):
"""Performs an asynchronous read-write transaction."""
spanner_client = AsyncClient()
instance = spanner_client.instance(instance_id)
database = instance.database(database_id)
database = await instance.database(database_id)

async def update_singer_lastname(transaction):
# Retrieve current name
Expand Down Expand Up @@ -110,7 +110,7 @@ async def async_read_only_transaction(instance_id, database_id):
"""Performs an asynchronous read-only transaction."""
spanner_client = AsyncClient()
instance = spanner_client.instance(instance_id)
database = instance.database(database_id)
database = await instance.database(database_id)

async with database.snapshot() as snapshot:
# Execute a read using standard KeySet
Expand Down
Loading