Skip to content

feat: support gemini-3.x models in loader and update default model to gemini-3.5-flash#17557

Draft
shuoweil wants to merge 15 commits into
mainfrom
shuowei-deprecate-gemini2p5
Draft

feat: support gemini-3.x models in loader and update default model to gemini-3.5-flash#17557
shuoweil wants to merge 15 commits into
mainfrom
shuowei-deprecate-gemini2p5

Conversation

@shuoweil

@shuoweil shuoweil commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

** STILL IN CLEAN UP STAGE"

  • Updated the default model in BQML GeminiTextGenerator to gemini-3.5-flash (instead of gemini-2.5-pro).
  • Registered gemini-3.1-flash-lite and gemini-3.5-flash endpoints in BQML model loader to prevent KeyError during model loading.
  • Updated all related docstrings, deprecation notes, warnings, and tests to align with the new defaults.
  • Updated Gemini model references across all sample notebooks to gemini-3.5-flash and fixed notebook formatting syntax to pass pre-commit checks.

Fixes #<519302924> 🦕

@shuoweil shuoweil self-assigned this Jun 23, 2026
@shuoweil shuoweil requested review from a team as code owners June 23, 2026 22:59
@shuoweil shuoweil requested review from GarrettWu, sycai and tswast and removed request for a team and tswast June 23, 2026 22:59
@shuoweil shuoweil marked this pull request as draft June 23, 2026 23:00

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the new Gemini models gemini-3.1-flash-lite and gemini-3.5-flash across BigQuery DataFrames ML, updates the default model for GeminiTextGenerator to gemini-2.5-pro, and updates deprecation warnings, notebooks, and tests accordingly. Feedback was provided to update the GeminiTextGenerator docstring to reflect the new default model, as it still refers to the old default.

Comment thread packages/bigframes/bigframes/ml/llm.py Outdated

if model_name is None:
model_name = "gemini-2.0-flash-001"
model_name = "gemini-2.5-pro"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The default model has been updated to "gemini-2.5-pro" here, but the docstring in GeminiTextGenerator (lines 451-452) still states that "gemini-2.0-flash-001" will be used by default. Please update the docstring to match this new default.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All docstrings have been updated.

@shuoweil shuoweil removed request for GarrettWu and sycai June 23, 2026 23:02
@shuoweil shuoweil changed the title feat: support gemini-3.x models in loader and update tests/notebooks feat: support gemini-3.x models in loader and update default model to gemini-3.5-flash Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant