feat: support gemini-3.x models in loader and update default model to gemini-3.5-flash#17557
Draft
shuoweil wants to merge 15 commits into
Draft
feat: support gemini-3.x models in loader and update default model to gemini-3.5-flash#17557shuoweil wants to merge 15 commits into
shuoweil wants to merge 15 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for the new Gemini models gemini-3.1-flash-lite and gemini-3.5-flash across BigQuery DataFrames ML, updates the default model for GeminiTextGenerator to gemini-2.5-pro, and updates deprecation warnings, notebooks, and tests accordingly. Feedback was provided to update the GeminiTextGenerator docstring to reflect the new default model, as it still refers to the old default.
|
|
||
| if model_name is None: | ||
| model_name = "gemini-2.0-flash-001" | ||
| model_name = "gemini-2.5-pro" |
Contributor
Contributor
Author
There was a problem hiding this comment.
All docstrings have been updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
** STILL IN CLEAN UP STAGE"
GeminiTextGeneratortogemini-3.5-flash(instead ofgemini-2.5-pro).gemini-3.1-flash-liteandgemini-3.5-flashendpoints in BQML model loader to preventKeyErrorduring model loading.gemini-3.5-flashand fixed notebook formatting syntax to pass pre-commit checks.Fixes #<519302924> 🦕