Skip to content

fix(crc32c): escape the version dot and anchor the pyenv check regex #17555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chalmerlowe wants to merge 5 commits into
base: main
Choose a base branch
from
+4 −3
Draft

fix(crc32c): escape the version dot and anchor the pyenv check regex #17555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc8c583
fix(crc32c): escape version dot and anchor pyenv check regex to preve…
chalmerlowe Jun 23, 2026
444a007
fix(crc32c): refactor pyenv check to avoid subshell and string compar…
chalmerlowe Jun 23, 2026
cea19e6
chore(ci): fix step ID typo and handle packages without unit tests in…
chalmerlowe Jun 23, 2026
a88e284
Merge branch 'main' into feat/fix-crc32c-osx-pyenv-build
chalmerlowe Jun 23, 2026
6c9328c
Adds a comment
chalmerlowe Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/google-crc32c/scripts/osx/build_python_wheel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@ eval "$(pyenv init --path)"

install_python_pyenv() {
version=$1

if [ -z "$(pyenv versions --bare | grep $version)" ]; then
# escapes the dot in the version number to avoid regex expansion issues.
escaped_version="${version//./\.}"
Comment thread
chalmerlowe marked this conversation as resolved.
if ! pyenv versions --bare | grep -q "^${escaped_version}\b"; then
echo "Python $version is not installed. Installing..."
pyenv install $version
echo "Python $version installed."
Expand Down
2 changes: 1 addition & 1 deletion packages/google-crc32c/scripts/osx/publish_python_wheel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

set -eo pipefail

if [ -z "$(pyenv versions --bare | grep 3.10)" ]; then
if ! pyenv versions --bare | grep -q "^3\.10\b"; then
echo "Python 3.10 is not installed. Installing..."
pyenv install 3.10
fi
Expand Down
Loading