Skip to content

chore: remove snapshot testing from gapic-node-processing #7283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pearigee wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: remove snapshot testing from gapic-node-processing #7283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
249 changes: 0 additions & 249 deletions packages/gapic-node-processing/__snapshots__/templating.test.js
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions packages/gapic-node-processing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"pretest": "npm run compile",
"samples-test": "echo 'FIXME: no sample tests'",
"system-test": "echo 'FIXME: no system tests'",
"test:snap": "SNAPSHOT_UPDATE=1 npm test",
"test": "cross-env c8 mocha --exit build/test",
"prelint": "npm install",
"precompile": "gts clean",
Expand All @@ -37,7 +36,6 @@
"gts": "^6.0.2",
"mocha": "^11.1.0",
"sinon": "^21.0.0",
"snap-shot-it": "^7.9.10",
"typescript": "^5.8.2"
},
"engines": {
Expand Down
7 changes: 0 additions & 7 deletions packages/gapic-node-processing/test/templating.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ import {compileTemplates} from '../src/templating';
import {join} from 'path';
import {execSync} from 'child_process';
import {mkdirSync, readdirSync, readFileSync} from 'fs';
// eslint-disable-next-line n/no-unpublished-import
import snapshot from 'snap-shot-it';
import * as assert from 'assert';
import {TemplateVars} from '../src/get-bootstrap-template-vars';

Expand Down Expand Up @@ -62,11 +60,6 @@ describe('tests for templates', () => {
folderName: 'google-cloud-keymanagement',
});

snapshot(readFileSync(join(templateDirWrite, '.OwlBot.yaml'), 'utf8'));
snapshot(
readFileSync(join(templateDirWrite, '.repo-metadata.json'), 'utf8'),
);
snapshot(readFileSync(join(templateDirWrite, 'LICENSE'), 'utf8'));
const packageJson = JSON.parse(
readFileSync(join(templateDirWrite, 'package.json'), 'utf8'),
);
Expand Down
Loading