chore(bigquery-jdbc): Force integration tests to use per-run datasets#13278
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the integration tests to use dynamically generated shared datasets instead of hardcoded dataset names, introducing automatic cleanup via JVM shutdown hooks. The reviewer identified that sharing a single dataset across multiple test classes can lead to test interference and metadata query pollution. To resolve this, the reviewer suggested introducing a getUniqueDataset() helper method in ITBase to provide isolated datasets for test classes that do not need to share resources.
keshavdandeva
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently tests rely on existing datasets. Some of them also try to create tables without unique names (e.g. FakeTable) which results in failures if two integration tests are running concurrently.
This change eliminates dependency on
JDBC_INTEGRATION_DATASETandJDBC_INTEGRATION_DATASET_2and relies on the new unique dataset that is removed up after the run.This will also allow us not to rely on table cleanup as the entire dataset will be removed.