Skip to content

chore(deps): update dependency google.cloud.storage.v1 to 4.15.0#15698

Merged
robertvoinescu-work merged 1 commit into
googleapis:mainfrom
robertvoinescu-work:chore/updateVersion
Jun 22, 2026
Merged

chore(deps): update dependency google.cloud.storage.v1 to 4.15.0#15698
robertvoinescu-work merged 1 commit into
googleapis:mainfrom
robertvoinescu-work:chore/updateVersion

Conversation

@robertvoinescu-work

@robertvoinescu-work robertvoinescu-work commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

b/525534270

replaces: #15677

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Google.Cloud.Storage.V1 dependency to version 4.15.0 and modifies the credential loading logic in Program.cs to use CredentialFactory.FromFile. Feedback points out that this change unnecessarily restricts the allowed credential types to service accounts, which will cause failures for other valid credential files (e.g., user credentials). It is recommended to revert to the more flexible GoogleCredential.FromFile method.

Comment thread tools/Google.Cloud.Tools.DocUploader/Program.cs
@robertvoinescu-work robertvoinescu-work merged commit 0d3a9d8 into googleapis:main Jun 22, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants