chore(deps): update dependency google.cloud.storage.v1 to 4.15.0#15698
Merged
robertvoinescu-work merged 1 commit intoJun 22, 2026
Merged
Conversation
1 task
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Google.Cloud.Storage.V1 dependency to version 4.15.0 and modifies the credential loading logic in Program.cs to use CredentialFactory.FromFile. Feedback points out that this change unnecessarily restricts the allowed credential types to service accounts, which will cause failures for other valid credential files (e.g., user credentials). It is recommended to revert to the more flexible GoogleCredential.FromFile method.
efevans
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/525534270
replaces: #15677