Skip to content

fix(SecretManagerHelper): Add missing PackAsTool property in csproj#15696

Merged
efevans merged 1 commit into
googleapis:mainfrom
efevans:tools/secrets-manager-properties
Jun 22, 2026
Merged

fix(SecretManagerHelper): Add missing PackAsTool property in csproj#15696
efevans merged 1 commit into
googleapis:mainfrom
efevans:tools/secrets-manager-properties

Conversation

@efevans

@efevans efevans commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

b/372695976

nextVersion explicitly set to avoid issues with librarian version requirements

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pipeline state configuration for Google.Cloud.Tools.SecretManagerHelper to set its next version to 1.0.0 and imports the shared DotnetToolProperties.xml properties in its project file. There are no review comments, and I have no feedback to provide.

@efevans efevans force-pushed the tools/secrets-manager-properties branch from fc5f044 to aba8220 Compare June 22, 2026 18:18
@efevans efevans marked this pull request as ready for review June 22, 2026 18:46
@efevans efevans requested a review from a team as a code owner June 22, 2026 18:46

@robertvoinescu-work robertvoinescu-work left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efevans efevans merged commit 63351a3 into googleapis:main Jun 22, 2026
12 checks passed
@efevans efevans deleted the tools/secrets-manager-properties branch June 22, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants