feat(storage): Add full object checksum validation for appendable uploads finalize#16245
Open
v-pratap wants to merge 12 commits into
Open
feat(storage): Add full object checksum validation for appendable uploads finalize#16245v-pratap wants to merge 12 commits into
v-pratap wants to merge 12 commits into
Conversation
…able uploads (googleapis#16110)" This reverts commit 6a3a627.
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors checksum handling and hash function management during appendable uploads. The review feedback identifies critical issues where removing the Crc32cHashFunction constructor and its recreation logic breaks checksum validation for resumed non-appendable uploads. Additionally, the reviewer recommends simplifying the UpdateChecksums signature, returning an explicit error if requested CRC32C validation cannot be performed due to missing metadata, and adding unit tests to cover the new validation paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.