feat(rest): enable PQC EC curves in libcurl#16243
Closed
scotthart wants to merge 3 commits into
Closed
Conversation
There was a problem hiding this comment.
Code Review
This pull request configures post-quantum cryptography (PQC) curves via CURLOPT_SSL_EC_CURVES when using libcurl 7.73.0 or later, and adds corresponding unit tests. The feedback suggests changing the log level from INFO to DEBUG when the option is unsupported or fails to set, which prevents log pollution and performance overhead on every request.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16243 +/- ##
==========================================
- Coverage 92.27% 92.26% -0.01%
==========================================
Files 2214 2214
Lines 206394 206436 +42
==========================================
+ Hits 190443 190470 +27
- Misses 15951 15966 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The errors that can result when a call to set
CURLOPT_SSL_EC_CURVESare not recoverable during program execution:CURLE_UNKNOWN_OPTION,CURLE_SSL_ENGINE_SETFAILED,CURLE_NOT_BUILT_IN,CURLE_BAD_FUNCTION_ARGUMENT,CURLE_OUT_OF_MEMORY.Thus, we can check once when the rest client is created and avoid log spam.