feat(ado.net): support more schema tables#778
Open
olavloite wants to merge 1 commit into
Open
Conversation
Add more standard schema tables to the ADO.NET driver. Also adds integration tests for those schema tables, and a new job for running those integration tests against the Spanner emulator.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements schema retrieval for 'Tables', 'Columns', 'Indexes', 'IndexColumns', and 'Foreign Keys' collections from Spanner's INFORMATION_SCHEMA in SpannerSchemaProvider.cs, along with corresponding mock server unit tests and emulator-based integration tests. The review feedback suggests dynamically retrieving the emulator host and port from the SPANNER_EMULATOR_HOST environment variable in the integration tests instead of hardcoding localhost:9010.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more standard schema tables to the ADO.NET driver.
Also adds integration tests for those schema tables, and a new job for running those integration tests against the Spanner emulator.