[scheduling] Improve error messages for pipeline scheduling failures. #3599
+181
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pipeline scheduling fails because the specified clock period is too small, the error message now includes the original clock period when suggesting a larger clock period. If the `minimize_clock_on_failure` option is enabled, the scheduler will first attempt to find the minimum feasible clock period before building a detailed infeasibility explanation at the original clock period. (In the other order, this always gave a false success at the smallest clock increment; we'd already changed the scheduler to find an infeasibility explanation, making it unsafe for reuse.) Also includes the original failure's diagnosed reason in our error messages, where enabled. New tests are added to verify these improved error messages. Co-developed with angelomatni1@, who diagnosed the issue, constructed the tests, and designed the new error messages. PiperOrigin-RevId: 847899675
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[scheduling] Improve error messages for pipeline scheduling failures.
When pipeline scheduling fails because the specified clock period is too small, the error message now includes the original clock period when suggesting a larger clock period. If the
minimize_clock_on_failureoption is enabled, the scheduler will first attempt to find the minimum feasible clock period before building a detailed infeasibility explanation at the original clock period. (In the other order, this always gave a false success at the smallest clock increment; we'd already changed the scheduler to find an infeasibility explanation, making it unsafe for reuse.)Also includes the original failure's diagnosed reason in our error messages, where enabled.
New tests are added to verify these improved error messages.
Co-developed with angelomatni1@, who diagnosed the issue, constructed the tests, and designed the new error messages.