Refactor algo in one place#1482
Closed
copybara-service[bot] wants to merge 0 commit into
Closed
Conversation
copybara-service
Bot
requested review from
abheesht17,
hgao327,
jiangyangmu,
lc5211,
s-noghabi,
sizhit2,
tianshub and
wang2yn84
as code owners
copybara-service
Bot
force-pushed
the
test_908254319
branch
from
67fcde5 to
c24674b
Compare
copybara-service
Bot
force-pushed
the
test_908254319
branch
from
c24674b to
eaa90af
Compare
copybara-service
Bot
force-pushed
the
test_908254319
branch
from
eaa90af to
6d75558
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor algo in one place
Move all loss function, advantage estimator into algo_core. So both agentic rl and non-agentic rl share same algorithms.