translations.txt: update allowed values for 'table_name' field#593
Open
felixguendling wants to merge 1 commit intogoogle:masterfrom
Open
translations.txt: update allowed values for 'table_name' field#593felixguendling wants to merge 1 commit intogoogle:masterfrom
felixguendling wants to merge 1 commit intogoogle:masterfrom
Conversation
add all tables that have translatable URL or Text fields
Collaborator
|
Related issue: #424 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allowed value for
table_name: add all tables that have translatable fields.Describe the Problem
According to the current reference, Fares v2 and Flex v2 are not translatable.
I think this happened through an oversight when adding Fares and Flex without updating the translations table.
Use Cases
It would be valuable to be able to translate the following fields:
rider_categories.rider_category_namerider_categories.eligibility_urlfare_media.fare_media_namefare_media.fare_media_typefare_media.fare_product_nameareas.area_namenetworks.network_namelocation_groups.location_group_namelocations.location_stop_namelocations.location_stop_descbooking_rules.messagebooking_rules.pickup_messagebooking_rules.drop_off_messagebooking_rules.phone_numberbooking_rules.info_urlbooking_rules.booking_urlProposed Solution
Extend the list of translatable values by:
rider_categoriesfare_mediafare_productsareasnetworkspathwayslevelslocation_groupslocationsbooking_rulesType of change
GTFS Schedule
GTFS Realtime
Additional Information
Another solution could be to use a more general wording that's not prone to this problem. Something like
Proposed Discussion Period
I would hope that everyone agrees that also Flex and Fares should be translatable.
However, since holiday season is approaching, it's probably better to give it 2 months.
Testing Details
I'm working on MOTIS translation support and MOTIS will support translating Fares and Flex values as well from the beginning.
Proposal Update Tracker