Assert raw-transfer layout assumptions; use base storage buffer#160
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_935376023
branch
6 times, most recently
from
ed23362 to
86a3269
Compare
Raw transfer DMAs physical bytes, so resolve the tensor's base storage buffer (not a materialized copy) and fail loudly if its block-major layout assumptions don't hold (dim-0 most-major, size a multiple of the slice, view spanning its base 1:1). PiperOrigin-RevId: 936190982
copybara-service
Bot
force-pushed
the
test_935376023
branch
from
86a3269 to
0a07c7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assert raw-transfer layout assumptions; use base storage buffer
Raw transfer DMAs physical bytes, so resolve the tensor's base storage
buffer (not a materialized copy) and fail loudly if its block-major
layout assumptions don't hold (dim-0 most-major, size a multiple of the
slice, view spanning its base 1:1).