Reclaim stale recv entries on timeout in CompleteReadRaw#158
Open
copybara-service[bot] wants to merge 1 commit into
Open
Reclaim stale recv entries on timeout in CompleteReadRaw#158copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_935372914
branch
2 times, most recently
from
47008b6 to
0f6b8e4
Compare
A RecvEntry stayed in active_recv_entries_ until its transfer completed or explicitly failed. If the producer died or never finished pushing, the entry (and the host staging slot it now holds) leaked permanently, eventually exhausting the staging pool. Give each RecvEntry a deadline and sweep expired ones in CompleteReadRaw, mirroring the existing send-side sweep: release the slot and report the request via failed_recving so the connector can recompute the blocks. PiperOrigin-RevId: 935372914
copybara-service
Bot
force-pushed
the
test_935372914
branch
from
0f6b8e4 to
6e6cb6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reclaim stale recv entries on timeout in CompleteReadRaw
A RecvEntry stayed in active_recv_entries_ until its transfer completed or
explicitly failed. If the producer died or never finished pushing, the
entry (and the host staging slot it now holds) leaked permanently,
eventually exhausting the staging pool. Give each RecvEntry a deadline and
sweep expired ones in CompleteReadRaw, mirroring the existing send-side
sweep: release the slot and report the request via failed_recving so the
connector can recompute the blocks.