Fix TLS 1.3 text appearing in security.tls.v1_2_server results - #1622
Open
IMINABO1 wants to merge 1 commit into
Open
Fix TLS 1.3 text appearing in security.tls.v1_2_server results#1622IMINABO1 wants to merge 1 commit into
IMINABO1 wants to merge 1 commit into
Conversation
TLS 1.3 detail lines were always appended to the TLS 1.2 server test output. Only include them when a valid TLS 1.3 certificate is what makes an invalid TLS 1.2 result compliant, so the result description for security.tls.v1_2_server otherwise only reports TLS 1.2. Fixes google#1529
|
I believe this may already be resolved by #1598. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLS 1.3 detail lines were always appended to the TLS 1.2 server test output. Only include them when a valid TLS 1.3 certificate is what makes an invalid TLS 1.2 result compliant, so the result description for security.tls.v1_2_server otherwise only reports TLS 1.2.
Updated the unit tests in testing/unit/tls/tls_module_test.py that pinned the old output; the intentional 'TLS 1.2 invalid + TLS 1.3 valid: Compliant' case still reports both versions since the TLS 1.3 result explains the verdict.
Fixes #1529