fix: add source context to parsing error messages#4546
Open
Harshit28j wants to merge 1 commit intogoogle:masterfrom
Open
fix: add source context to parsing error messages#4546Harshit28j wants to merge 1 commit intogoogle:masterfrom
Harshit28j wants to merge 1 commit intogoogle:masterfrom
Conversation
Contributor
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3518
When parse_vulnerabilities_from_data() fails to parse a vulnerability record, the error message now includes the filename that caused the issue.
Changes
Added an optional source_name parameter to parse_vulnerabilities_from_data() in osv/sources.py. When parsing fails and source_name is provided, the exception is wrapped with a
RuntimeErrorthat includes the filename.Files Modified
source_name=blob.nameat 3 call sitessource_name=pathat 1 call siteBefore vs After
Before:
After:
