ci: run apitester against PRs
#4354
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
commented
Nov 17, 2025
run_tests.sh
Outdated
| cd ./go/models/internal/validate/ && ./run_validate.sh | ||
|
|
||
| # Run the API tester | ||
| url="localhost:${DATASTORE_EMULATOR_PORT}" |
Collaborator
Author
There was a problem hiding this comment.
I think we might as well have the apitester itself handle this, or at least have a port variable, but I want to get this working first before doing any cleanup
Contributor
|
I think this should be in the run_test.sh script in the gcp/api folder |
G-Rath
force-pushed
the
apitester/run-on-prs
branch
from
f7e0390 to
4f9a50b
Compare
|
This pull request has not had any activity for 60 days and will be automatically closed in two weeks |
github-actions
bot
added
the
stale
Contributor
|
This is complete now. |
Contributor
|
#4557 for reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4309