git: Fix build - #16163
Merged
Merged
git: Fix build#16163
Conversation
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
|
arthurscchan is either the primary contact or is in the CCs list of projects/git. |
arthurscchan
marked this pull request as ready for review
September 22, 2026 08:37
DavidKorczynski
approved these changes
Sep 22, 2026
Merged
DavidKorczynski
pushed a commit
that referenced
this pull request
Sep 28, 2026
This PR reverts the language change for project git in #16163. Although project git is in the middle of the rust migration, most of the code is still in C/C++, so keeping the language in project.yaml preserve the original coverage report. Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git is in the middle of migrating to Rust. It currently compiles two main static libraries, libgit.a and libgitcore.a. The two reference each other, but the latter is only built when Rust is enabled. This migration broke the current OSS-Fuzz build, because libgitcore.a was missing when the fuzzers were linked. This PR fixes that by building the project on the Rust base image and including both static libraries, so the OSS-Fuzz build for git succeeds again.