refactor: move render scale histogram parameters: bin size, num bins, scale origin, to constructor#1060
Draft
seankmartin wants to merge 1 commit into
Draft
Conversation
previously these were all fixed constants. Then when volume rendering was introduced we made the origin be a constructor param to the render scale widget and the histogram stats. Here, we propose to make the bin size, number of bins and the scale origin all parts of the render scale histogram, and then have the render scale widget directly use all of these public attrs of the render scale histogram.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously these were all fixed constants. Then when volume rendering was introduced we made the origin be a constructor param to the render scale widget and the histogram stats. Here, we propose to make the bin size, number of bins and the scale origin all parts of the render scale histogram, and then have the render scale widget directly use all of these public attrs of the render scale histogram.
The intent here is to functionally change nothing. But it would allow the volume rendering origin change to be cleaner. And in the future we are consider to propose a different cap on the number of volume rendering samples, at which point these parameters will be adjusted for that purpose.