Conversation
Taken from the upstream repo https://github.com/Omnibus-Type/Saira_Stencil at commit Omnibus-Type/Saira_Stencil@426fb33.
|
It's a VF replacement, but onboarded as a new font to replace Saira Stencil One |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
FontSpector reportfontspector version: 1.6.0 Checks with FATAL resultsThese must be addressed first. [1] ofl/sairastencil/SairaStencil[wdth,wght].ttf💥 ERROR Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
[1] ofl/sairastencil/SairaStencil-Italic[wdth,wght].ttf💥 ERROR Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
All other checks[4] ofl/sairastencil🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field. (googlefonts/metadata/consistent_repo_urls)
🔥 FAIL Tofu should not be shown in sample texts. (googlefonts/tofu)
|
| Message | Languages |
|---|---|
| Mandatory orthography codepoints: | * yo_Latn (Yoruba) |
| The following base characters are missing from the font: Ǹ, ǹ, ḿ, Ḿ | |
| The following mark characters are missing from the font: ̩ | |
| Mandatory orthography codepoints: | * fat_Latn (Fanti) |
| The following base characters are missing from the font: Ɔ, ɔ, Ɛ, ɛ | |
| Mandatory orthography codepoints: | * dyu_Latn (Dyula) |
| The following base characters are missing from the font: Ɛ, ɛ, ɔ, Ɔ | |
| Mandatory orthography codepoints: | * ff_Latn (Fulah) |
| The following base characters are missing from the font: Ƴ, Ɗ, ƴ, ɗ, ɓ, Ɓ | |
| Mandatory orthography codepoints: | * ha_Latn (Hausa) |
| The following base characters are missing from the font: Ɗ, ɗ, Ƙ, ƙ, ɓ, Ɓ, ƴ, Ƴ | |
| Mandatory orthography codepoints: | * bm_Latn (Bambara) |
| The following base characters are missing from the font: Ɛ, ɔ, Ɔ, ɛ | |
| Mandatory orthography codepoints: | * tw_akuapem_Latn (Akuapem Twi) |
| The following base characters are missing from the font: ɛ, ɔ, Ɔ, Ɛ |
⚠️ WARN Warning language shaping:
| Message | Languages |
|---|---|
| Auxiliary orthography codepoints: | * yo_Latn (Yoruba) |
| The following auxiliary characters are missing from the font: e̩ | |
| The following auxiliary characters are missing from the font: E̩ | |
| The following auxiliary characters are missing from the font: é̩ | |
| The following auxiliary characters are missing from the font: É̩ | |
| The following auxiliary characters are missing from the font: è̩ | |
| The following auxiliary characters are missing from the font: È̩ | |
| The following auxiliary characters are missing from the font: ê̩ | |
| The following auxiliary characters are missing from the font: Ê̩ | |
| The following auxiliary characters are missing from the font: ě̩ | |
| The following auxiliary characters are missing from the font: Ě̩ | |
| The following auxiliary characters are missing from the font: o̩ | |
| The following auxiliary characters are missing from the font: O̩ | |
| The following auxiliary characters are missing from the font: ó̩ | |
| The following auxiliary characters are missing from the font: Ó̩ | |
| The following auxiliary characters are missing from the font: ò̩ | |
| The following auxiliary characters are missing from the font: Ò̩ | |
| The following auxiliary characters are missing from the font: ô̩ | |
| The following auxiliary characters are missing from the font: Ô̩ | |
| The following auxiliary characters are missing from the font: ǒ̩ | |
| The following auxiliary characters are missing from the font: Ǒ̩ | |
| The following auxiliary characters are missing from the font: s̩ | |
| The following auxiliary characters are missing from the font: S̩ | |
| Auxiliary orthography codepoints: | * ig_Latn (Igbo) |
| The following auxiliary characters are missing from the font: ḿ | |
| The following auxiliary characters are missing from the font: Ḿ | |
| The following auxiliary characters are missing from the font: ǹ | |
| The following auxiliary characters are missing from the font: Ǹ | |
| The following auxiliary characters are missing from the font: ɛ | |
| The following auxiliary characters are missing from the font: Ɛ | |
| The following auxiliary characters are missing from the font: ɵ | |
| The following auxiliary characters are missing from the font: Ɵ | |
| Auxiliary orthography codepoints: | * en_Latn (English) |
| The following auxiliary characters are missing from the font: ʻ | |
| Auxiliary orthography codepoints: | * fi_Latn (Finnish) |
| The following auxiliary characters are missing from the font: Ǥ | |
| The following auxiliary characters are missing from the font: Ȟ | |
| The following auxiliary characters are missing from the font: Ǩ | |
| The following auxiliary characters are missing from the font: Ʒ | |
| The following auxiliary characters are missing from the font: Ǯ | |
| The following auxiliary characters are missing from the font: ǥ | |
| The following auxiliary characters are missing from the font: ȟ | |
| The following auxiliary characters are missing from the font: ǩ | |
| The following auxiliary characters are missing from the font: ʒ | |
| The following auxiliary characters are missing from the font: ǯ |
⚠️ WARN Check if each glyph has the recommended amount of contours. (contour_count)
-
⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are
inferred from the typical amounts of contours observed in a
large collection of reference font families. The divergences
listed below may simply indicate a significantly different
design on some of your glyphs. On the other hand, some of these
may flag actual bugs in the font such as glyphs mapped to an
incorrect codepoint. Please consider reviewing the design and
codepoint assignment of these to make sure they are correct.The following glyphs do not have the recommended number of contours:
- uni01F1 (U+01F1): found 5, expected one of: [3, 4]
- uni01F2 (U+01F2): found 5, expected one of: [3, 4]
- uni01F4 (U+01F4): found 4, expected one of: [2, 3]
- uni1E24 (U+1E24): found 3, expected one of: [2, 4]
- S (U+0053): found 3, expected one of: [1, 2, 5]
- Sacute (U+015A): found 4, expected one of: [2, 3, 6]
- uni1E62 (U+1E62): found 4, expected one of: [2]
- G_tilde.loclGUA (unencoded): found 4, expected one of: [2]
- Y.loclGUA (unencoded): found 3, expected one of: [1]
... and 73 others [code: contour-count]
⚠️ WARN Check math signs have the same width. (math_signs_width)
⚠️ WARN The most common width is 540 among a set of 13 math glyphs.
The following math glyphs have a different width, though:
width=465: multiply
width=541: greater, less, lessequal, greaterequal
width=497: approxequal
width=539: logicalnot [code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs (unreachable_glyphs)
⚠️ WARN The following glyphs could not be reached by codepoint or substitution rules:
- G_tilde.loclGUA
- g_tilde.loclGUA
- notdef
- orn.017
- Gtilde.loclGUA.ss01 [code: unreachable-glyphs]
⚠️ WARN Ensure dotted circle glyph is present and can attach marks. (dotted_circle)
⚠️ WARN No dotted circle glyph present [code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that
replace the dot. (soft_dotted)
⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings:
-
į̌
-
į̄
-
į̃
-
į́
-
į̀
-
į̂
-
ị̄
-
ị̃
-
ị́
... and 2 othersThe dot of soft dotted characters should disappear in other cases, for example: -
į̊
-
į̉
-
į̒
-
į̑
-
į̆
-
į̋
-
į̏
-
į̇
-
į̈
... and 10 others [code: soft-dotted]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
⚠️ WARN Check font follows the Google Fonts vertical metric schema (googlefonts/vertical_metrics)
⚠️ WARN We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.574x (1574) [code: bad-hhea-range]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| SairaStencil-Italic[wdth,wght].ttf | |
|---|---|
| Dehinted Size | 402940 |
| Hinted Size | 402964 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.101 [code: version-not-detected]
[1] ofl/sairastencil/OFL.txt
⚠️ WARN Check OFL body text is correct. (googlefonts/license/OFL_body_text)
⚠️ WARN The OFL.txt body text is incorrect. Please use https://github.com/googlefonts/Unified-Font-Repository/blob/main/OFL.txt as a template. You should only modify the first line.
Lines changed:
[code: incorrect-ofl-body-text]
[1] ofl/sairastencil/article/ARTICLE.en_us.html
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
- ℹ️ INFO Found a git repo URL: https://github.com/Omnibus-Type/Saira [code: url-found]
[14] ofl/sairastencil/SairaStencil[wdth,wght].ttf
🔥 FAIL Shapes languages in all GF glyphsets. (googlefonts/glyphsets/shape_languages)
- 🔥 FAIL Failed language shaping:
| Message | Languages |
|---|---|
| Mandatory orthography codepoints: | * bm_Latn (Bambara) |
| The following base characters are missing from the font: Ɛ, ɛ, ɔ, Ɔ | |
| Mandatory orthography codepoints: | * ff_Latn (Fulah) |
| The following base characters are missing from the font: Ɓ, ɓ, Ƴ, ɗ, Ɗ, ƴ | |
| Mandatory orthography codepoints: | * ha_Latn (Hausa) |
| The following base characters are missing from the font: Ƴ, ɗ, ƴ, ƙ, Ɓ, Ƙ, Ɗ, ɓ | |
| Mandatory orthography codepoints: | * yo_Latn (Yoruba) |
| The following base characters are missing from the font: ḿ, Ḿ, ǹ, Ǹ | |
| The following mark characters are missing from the font: ̩ | |
| Mandatory orthography codepoints: | * fat_Latn (Fanti) |
| The following base characters are missing from the font: ɔ, Ɛ, ɛ, Ɔ | * tw_akuapem_Latn (Akuapem Twi) |
| Mandatory orthography codepoints: | * dyu_Latn (Dyula) |
| The following base characters are missing from the font: ɔ, Ɔ, Ɛ, ɛ |
⚠️ WARN Warning language shaping:
| Message | Languages |
|---|---|
| Auxiliary orthography codepoints: | * fi_Latn (Finnish) |
| The following auxiliary characters are missing from the font: Ǥ | |
| The following auxiliary characters are missing from the font: Ȟ | |
| The following auxiliary characters are missing from the font: Ǩ | |
| The following auxiliary characters are missing from the font: Ʒ | |
| The following auxiliary characters are missing from the font: Ǯ | |
| The following auxiliary characters are missing from the font: ǥ | |
| The following auxiliary characters are missing from the font: ȟ | |
| The following auxiliary characters are missing from the font: ǩ | |
| The following auxiliary characters are missing from the font: ʒ | |
| The following auxiliary characters are missing from the font: ǯ | |
| Auxiliary orthography codepoints: | * ig_Latn (Igbo) |
| The following auxiliary characters are missing from the font: ḿ | |
| The following auxiliary characters are missing from the font: Ḿ | |
| The following auxiliary characters are missing from the font: ǹ | |
| The following auxiliary characters are missing from the font: Ǹ | |
| The following auxiliary characters are missing from the font: ɛ | |
| The following auxiliary characters are missing from the font: Ɛ | |
| The following auxiliary characters are missing from the font: ɵ | |
| The following auxiliary characters are missing from the font: Ɵ | |
| Auxiliary orthography codepoints: | * en_Latn (English) |
| The following auxiliary characters are missing from the font: ʻ | |
| Auxiliary orthography codepoints: | * yo_Latn (Yoruba) |
| The following auxiliary characters are missing from the font: e̩ | |
| The following auxiliary characters are missing from the font: E̩ | |
| The following auxiliary characters are missing from the font: é̩ | |
| The following auxiliary characters are missing from the font: É̩ | |
| The following auxiliary characters are missing from the font: è̩ | |
| The following auxiliary characters are missing from the font: È̩ | |
| The following auxiliary characters are missing from the font: ê̩ | |
| The following auxiliary characters are missing from the font: Ê̩ | |
| The following auxiliary characters are missing from the font: ě̩ | |
| The following auxiliary characters are missing from the font: Ě̩ | |
| The following auxiliary characters are missing from the font: o̩ | |
| The following auxiliary characters are missing from the font: O̩ | |
| The following auxiliary characters are missing from the font: ó̩ | |
| The following auxiliary characters are missing from the font: Ó̩ | |
| The following auxiliary characters are missing from the font: ò̩ | |
| The following auxiliary characters are missing from the font: Ò̩ | |
| The following auxiliary characters are missing from the font: ô̩ | |
| The following auxiliary characters are missing from the font: Ô̩ | |
| The following auxiliary characters are missing from the font: ǒ̩ | |
| The following auxiliary characters are missing from the font: Ǒ̩ | |
| The following auxiliary characters are missing from the font: s̩ | |
| The following auxiliary characters are missing from the font: S̩ |
⚠️ WARN Check if each glyph has the recommended amount of contours. (contour_count)
-
⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are
inferred from the typical amounts of contours observed in a
large collection of reference font families. The divergences
listed below may simply indicate a significantly different
design on some of your glyphs. On the other hand, some of these
may flag actual bugs in the font such as glyphs mapped to an
incorrect codepoint. Please consider reviewing the design and
codepoint assignment of these to make sure they are correct.The following glyphs do not have the recommended number of contours:
- uni01F1 (U+01F1): found 5, expected one of: [3, 4]
- uni01F2 (U+01F2): found 5, expected one of: [3, 4]
- uni01F4 (U+01F4): found 4, expected one of: [2, 3]
- uni1E24 (U+1E24): found 3, expected one of: [2, 4]
- S (U+0053): found 3, expected one of: [1, 2, 5]
- Sacute (U+015A): found 4, expected one of: [2, 3, 6]
- uni1E62 (U+1E62): found 4, expected one of: [2]
- G_tilde.loclGUA (unencoded): found 4, expected one of: [2]
- Y.loclGUA (unencoded): found 3, expected one of: [1]
... and 76 others [code: contour-count]
⚠️ WARN Check math signs have the same width. (math_signs_width)
⚠️ WARN The most common width is 540 among a set of 13 math glyphs.
The following math glyphs have a different width, though:
width=467: multiply
width=497: approxequal
width=541: less, greater, lessequal, greaterequal
width=539: logicalnot [code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs (unreachable_glyphs)
⚠️ WARN The following glyphs could not be reached by codepoint or substitution rules:
- G_tilde.loclGUA
- g_tilde.loclGUA
- Gtilde.loclGUA.ss01 [code: unreachable-glyphs]
⚠️ WARN Ensure variable fonts have relatively consistent sidebearings. (suspicious_sidebearings)
-
⚠️ WARN Glyph "numbersign" has suspiciously high variation (z-score 11.43) in right sidebearings at locations:
wght=100.00, wdth=125.00
wght=279.68, wdth=125.00 [code: large-rsb-variation] -
⚠️ WARN Glyph "ellipsis" has suspiciously high variation (z-score 10.08) in advance widths at locations:
wght=279.68, wdth=100.00
wght=397.75, wdth=100.00
wght=489.80, wdth=100.00
wght=575.86, wdth=100.00 [code: large-aw-variation]
⚠️ WARN Ensure dotted circle glyph is present and can attach marks. (dotted_circle)
⚠️ WARN No dotted circle glyph present [code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that
replace the dot. (soft_dotted)
⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings:
-
ị̃
-
ị̂
-
ị̄
-
ị́
-
ị̀
-
į̃
-
į̌
-
į̂
-
į̄
... and 2 othersThe dot of soft dotted characters should disappear in other cases, for example: -
ị̋
-
ị̌
-
ị̑
-
ị̈
-
ị̉
-
ị̊
-
ị̒
-
ị̏
-
ị̆
... and 10 others [code: soft-dotted]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
⚠️ WARN Check font follows the Google Fonts vertical metric schema (googlefonts/vertical_metrics)
⚠️ WARN We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.574x (1574) [code: bad-hhea-range]
ℹ️ INFO Checking OS/2 fsSelection value. (opentype/xavgcharwidth)
- ℹ️ INFO OS/2 xAvgCharWidth is 565 but it should be 564 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at com.google.fonts/test/034: xAvgCharWidth bakery vs glyphs vs font val fonttools/fontbakery#1622 [code: xAvgCharWidth-close]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| SairaStencil[wdth,wght].ttf | |
|---|---|
| Dehinted Size | 491288 |
| Hinted Size | 491312 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.101 [code: version-not-detected]
[2] ofl/sairastencil/METADATA.pb
⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (googlefonts/metadata/designer_profiles)
⚠️ WARN It seems that hectorgatti is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
ℹ️ INFO Check METADATA.pb parses correctly (googlefonts/metadata/validate)
- ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]
Summary
| 💥 ERROR | 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|---|
| 2 | 10 | 22 | 12 | 271 | 67 |
| 1% | 3% | 6% | 3% | 72% | 18% |
Taken from the upstream repo https://github.com/Omnibus-Type/Saira_Stencil at commit Omnibus-Type/Saira_Stencil@426fb33.
PR Checklist:
PR
QA
Specifics
primary_scriptdefinition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsetsdefinitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong,chinese-simplified,chinese-traditional,korean,japanese.Release
minisite_urldefinition in the METADATA.pb file for commissioned projectstagsare added for NEW FONTS