Conversation
RamSaw
left a comment
RamSaw
left a comment
There was a problem hiding this comment.
Looks good, thank you! Let's fix small nits, I will take another look and submit likely.
| ], | ||
|
|
||
| ) | ||
| maven_install( |
There was a problem hiding this comment.
why should it be a separate maven install?
There was a problem hiding this comment.
discussed offline: it is because we need different scala version here (2.12) and above we use (2.13);
let's add this comment in code
| "org.scala-lang:scala-library:%s" % SCALA_LIBRARY_TAG, | ||
| "info.picocli:picocli:4.7.6", | ||
| # For Apache Spark Runner testing locally | ||
| "org.apache.spark:spark-streaming_%s:%s" % (2.12, SPARK_TAG), |
There was a problem hiding this comment.
why it should be here and the other deps in separate maven install?
| @@ -0,0 +1,36 @@ | |||
| # Copyright 2024 Google LLC | |||
There was a problem hiding this comment.
there is already examples/pipelinedp4j/beam/src/main/java/com/google/privacy/differentialprivacy/pipelinedp4j/examples/BUILD.bazel
| <?xml version="1.0" encoding="UTF-8"?> | ||
|
|
||
| <!-- | ||
| Copyright 2024 Google LLC |
There was a problem hiding this comment.
could you revert these formatting changes for better diff?
| @@ -0,0 +1,36 @@ | |||
| # Copyright 2024 Google LLC | |||
|
|
||
| View the results with `cat output-spark-runner.txt`. | ||
|
|
||
| # Build and execute locally |
| @@ -159,6 +159,53 @@ For Spark the output is written to a folder and the | |||
| result is stored in a file whose name starts with `part-00000`: `cat | |||
There was a problem hiding this comment.
add exaplanations how to run with bazel
| @@ -159,6 +159,53 @@ For Spark the output is written to a folder and the | |||
| result is stored in a file whose name starts with `part-00000`: `cat | |||
There was a problem hiding this comment.
nit: could you add a note somewhere in the beginning of bazel and maven instructions to reference yml files saying that these yml files for CI essential show how we build these examples test.
2 participants
No description provided.