You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 5, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Aug 5, 2024. It is now read-only.
Okay, but I think I would wait till #2 gets merged, for others, I am not so sure, like the cpp needs a csproj and the c# code would need a .sln file in order for them to be buildable, right.
May be we can do separate pull requests for each of them.
Suggestions ?
.csproj is for C#. The current C++ implementation seems to use QMake to build. I prefer calling it "Qt implementation" than a "C++ implementation" because Qt is a hard compile time requirement.
At least we can start testing Python versions? The JavaScript version also needs to be updated after #13.
@mithuns I think it has to do with test discovery. I suggest not investing too much time in this unless @NeilFraser show interest, because IIUC he is the maintainer of this repository.
Activity
mithuns commentedon May 21, 2018
Would travis-ci work ? Or is there a preference on the ci tool ?
FranklinYu commentedon May 21, 2018
@mithuns Travis CI is the most popular one, but there are many out there (like Semaphore, CircleCI, Codeship). Any of them would help.
Note that Travis CI (and many others) doesn't support Windows, so typically they are combined with AppVeyor, the only Windows player in town (AFAIK).
mithuns commentedon May 23, 2018
Okay, but I think I would wait till #2 gets merged, for others, I am not so sure, like the cpp needs a csproj and the c# code would need a .sln file in order for them to be buildable, right.
May be we can do separate pull requests for each of them.
Suggestions ?
FranklinYu commentedon May 23, 2018
.csprojis for C#. The current C++ implementation seems to use QMake to build. I prefer calling it "Qt implementation" than a "C++ implementation" because Qt is a hard compile time requirement.At least we can start testing Python versions? The JavaScript version also needs to be updated after #13.
mithuns commentedon May 29, 2018
@FranklinYu hey, so I created something to try out, the python builds are showing success, but seems like no tests are being run, can you please take a look and suggest something.
https://travis-ci.org/mithuns/diff-match-patch/jobs/384997323
FranklinYu commentedon May 29, 2018
@mithuns I think it has to do with test discovery. I suggest not investing too much time in this unless @NeilFraser show interest, because IIUC he is the maintainer of this repository.
Add basic NPM boilerplate. Apply API changes from https://github.com/…