Repository navigation
Conversation
rmuthiah
force-pushed
the
remove-confui
branch
3 times, most recently
from
October 31, 2026 00:05
e78f4b4 to
1468ebf
Compare
rmuthiah
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
rmuthiah
force-pushed
the
remove-confui
branch
from
October 31, 2026 02:04
1468ebf to
c8b6000
Compare
Remove host/libs/confui, the ScreenConnector multiplexer in host/libs/screen_connector, and the confirmation UI server and virtual input wiring in host/frontend/webrtc so DisplayHandler owns the WaylandServer directly again. Adapted from aosp/3096313 (ff95eab / 6f9d2b7). Bug: b/342168898 Bug: b/430308370 Assisted-by: Jetski:Gemini
Finish removing the host side of ConfirmationUI on top of "Nuke confui" (aosp/3096313 / ff95eab): - Delete common/libs/confui and the confirmation UI signing library and server in common/libs/security and host/commands/secure_env. - Stop creating confui_fifo_vm.{in,out} in run_cvd and expose /dev/hvc8 as a sink on crosvm, matching QEMU. - Set androidboot.enable_confirmationui=0 in assemble_cvd for every VMM so guests that still ship the HAL start it and return UNIMPLEMENTED instead of hanging on /dev/hvc8 (fixing the b/341400441 failure that caused aosp/3096313 to be reverted in aosp/3155712). - Keep the legacy --confui_in_fd/--confui_out_fd flags in webRTC and the -confui_server_fd socket in run_cvd/secure_env for mixed-binary compatibility. Bug: b/430308370 Bug: b/342168898 Bug: b/545190664 Assisted-by: Jetski:Gemini
rmuthiah
force-pushed
the
remove-confui
branch
from
October 31, 2026 02:30
c8b6000 to
3f56fc6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuttlefish no longer supports the ConfirmationUI HAL, and the HAL is on its way out of the platform. This PR removes the host side in two commits:
Jason Macnak <natsu@google.com>, adapted fromaosp/3096313/ff95eab83/6f9d2b7568b0, b/342168898): removeshost/libs/confui, theScreenConnectormultiplexer inhost/libs/screen_connector, and the confirmation UI server and virtual input wiring inhost/frontend/webrtcsoDisplayHandlerownsWaylandServerdirectly again.common/libs/confuiand the confirmation UI signing library and server incommon/libs/securityandhost/commands/secure_env.confui_fifo_vm.{in,out}inrun_cvdand exposes/dev/hvc8as a sink on crosvm, matching QEMU.androidboot.enable_confirmationui=0inassemble_cvdfor every VMM so guests that still ship the HAL start it and returnUNIMPLEMENTEDinstead of hanging on/dev/hvc8(fixing the b/341400441 failure that causedaosp/3096313to be reverted inaosp/3155712).--confui_in_fd/--confui_out_fdflags inwebRTCand the-confui_server_fdsocket inrun_cvd/secure_envfor mixed-binary compatibility.