-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix: add sqlitesessionservice to init py file to fix the import errors #4034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @jawherkh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an importability issue for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Response from ADK Triaging Agent Hello @jawherkh, thank you for your contribution! Before we can review your pull request, you'll need to sign the Contributor License Agreement (CLA). You can find more information at https://cla.developers.google.com/. Also, for bug fixes like this, we recommend associating the PR with a GitHub issue. If an issue doesn't exist, please consider creating one to describe the problem this PR is solving. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly exposes the SqliteSessionService to make it importable from the adk.sessions package. My review includes two suggestions to maintain alphabetical ordering in the __init__.py file, which improves code readability and consistency, following standard Python conventions (PEP 8).
| from .session import Session | ||
| from .state import State | ||
| from .vertex_ai_session_service import VertexAiSessionService | ||
|
|
||
| from .sqlite_session_service import SqliteSessionService |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To maintain consistency and follow PEP 8 guidelines for import ordering, please sort the local imports alphabetically by module name. The new sqlite_session_service import should be placed between session and state.
| from .session import Session | |
| from .state import State | |
| from .vertex_ai_session_service import VertexAiSessionService | |
| from .sqlite_session_service import SqliteSessionService | |
| from .session import Session | |
| from .sqlite_session_service import SqliteSessionService | |
| from .state import State | |
| from .vertex_ai_session_service import VertexAiSessionService |
| 'BaseSessionService', | ||
| 'DatabaseSessionService', | ||
| 'InMemorySessionService', | ||
| 'Session', | ||
| 'State', | ||
| 'VertexAiSessionService', | ||
| 'SqliteSessionService', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To maintain consistency and readability, please keep the __all__ list sorted alphabetically. SqliteSessionService should be placed between Session and State.
| 'BaseSessionService', | |
| 'DatabaseSessionService', | |
| 'InMemorySessionService', | |
| 'Session', | |
| 'State', | |
| 'VertexAiSessionService', | |
| 'SqliteSessionService', | |
| 'BaseSessionService', | |
| 'DatabaseSessionService', | |
| 'InMemorySessionService', | |
| 'Session', | |
| 'SqliteSessionService', | |
| 'State', | |
| 'VertexAiSessionService', |
|
Hi @jawherkh Thank you for your contribution! It appears you haven't yet signed the Contributor License Agreement (CLA). Please visit https://cla.developers.google.com/ to complete the signing process. Once the CLA is signed, we'll be able to proceed with the review of your PR. Thank you! |
|
@ryanaiagent CLA signed and complete! |
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
The
SqliteSessionServicewas implemented but not exposed in theadk.sessionsmodule's__init__.py, making it unavailable for import via the top-level package.Solution:
Added
SqliteSessionServiceto the__init__.pyfile's imports and__all__list, ensuring it can be imported directly fromadk.sessions.Testing Plan
Unit Tests:
Please include a summary of passed
pytestresults.Manual End-to-End (E2E) Tests:
SqliteSessionServicecan now be imported fromadk.sessionswithout errors.Checklist
Additional context
This change improves usability by making
SqliteSessionServiceavailable for direct import from theadk.sessionspackage. No other code changes were made.