fix: branch filtering in ParallelAgent subagents#720
Open
jkumz wants to merge 1 commit intogoogle:mainfrom
Open
fix: branch filtering in ParallelAgent subagents#720jkumz wants to merge 1 commit intogoogle:mainfrom
jkumz wants to merge 1 commit intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
N/A
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed go test results.
A new test suite (
TestContentsRequestProcessor_IncludeContentsNone_ParallelBranch) was added tocontents_processor_test.goand passes locally. Specifically, this verifies two complex edge cases for parallel interactions:FirstModelCall_AlphaFCPresent: Verifies that if sibling agent A yields aFunctionCallon its branch, agent B still correctly anchors onto the root user message without being interrupted.SecondModelCall_BetaFCFRPresent: Verifies that agent B successfully scans backward past sibling agent A's events to retrieve its own context (FunctionCallandFunctionResponse) as well as the root user message to prevent the empty-context crash.Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
N/A
Checklist
Additional context
N/A