cloud run docs: Add authentication prerequisites to deployment guide#1277
Open
hari-silvers wants to merge 4 commits intogoogle:mainfrom
Open
cloud run docs: Add authentication prerequisites to deployment guide#1277hari-silvers wants to merge 4 commits intogoogle:mainfrom
hari-silvers wants to merge 4 commits intogoogle:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a Prerequisites section to the README for deploying a Gemini-based agent on Cloud Run, including authentication steps and API enablement. The review feedback highlights that the requirement for Application Default Credentials is misleading for this deployment context and suggests including additional necessary APIs, such as Artifact Registry and IAM, to ensure the workflow functions correctly.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE NO - 1271
Problem
it's not that much of change but the deployment guide (
deploy.sh) usesgcloudcommands but does not mentionauthentication steps. Users who are not authenticated will face failures
when running the script.
Proposed Fix
Add a Prerequisites section to the README after the Introduction that covers:
gcloud auth logingcloud auth application-default loginThe proposed changes rendered in the

A2UI\samples\agent\adk\gemini_enterprise\cloud_run\README.mdis shown below:Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.