Adding support of subgame equilibirum computation in IIEFGs.#1489
Open
alexunderch wants to merge 3 commits intogoogle-deepmind:masterfrom
Open
Adding support of subgame equilibirum computation in IIEFGs.#1489alexunderch wants to merge 3 commits intogoogle-deepmind:masterfrom
alexunderch wants to merge 3 commits intogoogle-deepmind:masterfrom
Conversation
Collaborator
|
Thanks! |
lanctot
reviewed
Mar 7, 2026
Collaborator
|
BTW about this: "Add the implementation for C++ ortools version": we've remove the testing of the OpenSpiel build with OR-Tools from GitHub Actions and will probably mark it as unmaintained as of OpenSpiel 2.0. So might not be worth the effort. Having the Python implementation is enough -- if anybody wants to extend it to C++, they can. :) |
Contributor
Author
|
@lanctot , I made several substantial changes:
|
Contributor
Author
|
related to #1467, however, I don't understand why the solution is like that. There's some logic behind the comments, but there's a question if all together can be viewed as some method. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pythonAdd the implementation for C++ ortools versionNow the implementation just extends current solver with noise in accordance with the paper. However, there're 2 questions, whether I need explicitly state the slack variables (currently they are under control of the solver, AIs told me this) and to implement all the tests + pygambit eval, showing that it works. To make it simpler to criticise, I make the PR public.
Current simplest tests (just computing values and policies pass)
ETA: 2-3 weeks.
@lanctot is it okay to start with that simple of extenstion? Because we don't actually converge to the equilibrium at the limit, only approximately. For the former, iirc, I need to implement one of: symbolic solver or Lemke algo.