feat(core): added gh workflow that adds 'contributor' label to PRs/Is…#8
feat(core): added gh workflow that adds 'contributor' label to PRs/Is…#8
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c13633eb5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const isPR = !!context.payload.pull_request; | ||
| const issueNumber = isPR ? context.payload.pull_request.number : context.payload.issue.number; | ||
| const authorAssociation = isPR ? context.payload.pull_request.author_association : context.payload.issue.author_association; | ||
|
|
||
| if (authorAssociation === 'CONTRIBUTOR') { |
There was a problem hiding this comment.
Label misses first-time contributors
The workflow only adds the label when author_association is exactly 'CONTRIBUTOR', but GitHub uses values like FIRST_TIME_CONTRIBUTOR/FIRST_TIMER for first-time external contributors. That means new contributors’ PRs/issues won’t get the “contributor” label, which contradicts the stated intent to label contributor PRs/issues. Consider including the first-time values (or explicitly documenting that only repeat contributors are labeled).
Useful? React with 👍 / 👎.
…sues
What does this PR do?
How did you verify your code works?