Bump version to get fix - #271
Open
andydotxyz wants to merge 2 commits into
Open
Conversation
Contributor
|
Thanks ! |
Contributor
Author
|
Updated to resolve the new issues (all in the static generator) fix is up at go-text/typesetting-utils#28 but has test failures... I may have to leave it here for now |
Contributor
Author
|
I cannot tell if the test failures here relate to bad internal checks, or if the variable that was supposedly doing nothing is actually being checked internally and that staticcheck was wrong. Stumped I'm afraid but hopefully someone who knows more can cast an eye over this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to dominikh/go-tools#1711 this should fix the check errors we see