Skip to content

Conversation

@fredbi
Copy link
Member

@fredbi fredbi commented Jan 20, 2026

Change type

Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update

Short description

Fixes

Full description

Checklist

  • I have signed all my commits with my name and email (see DCO. This does not require a PGP-signed commit
  • I have rebased and squashed my work, so only one commit remains
  • I have added tests to cover my changes.
  • I have properly enriched go doc comments in code.
  • I have properly documented any breaking change.

fredbi added 10 commits January 19, 2026 19:01
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Support for IsOfType, IsNotOfType assertions.

Originally posted as stretchr#1805

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Originally from upstream: stretchr#1685

NOTE: did not add SeqElementsMatch as the origin PR suggested. Contains
is good enough.

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
expectations

Now the generic version and the reflect-based version are functionally
equivalent and aligned with the documentation - no quirks no more.

test: refactored tests

Tests for functions of the order domain fully refactored to eliminate
code duplicate and remain rather maintainable.

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
all equality assertions should fail the same when input is a function.

fix: type safety added CanInterface guard to EqualExportedValues (even
if it seems currently impossible to make it panic with current reflect)

test: refactored equal tests

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 96.63043% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.63%. Comparing base (d43d8b5) to head (5ea42d8).
⚠️ Report is 11 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
codegen/internal/model/model.go 0.00% 17 Missing ⚠️
internal/assertions/equal.go 85.10% 4 Missing and 3 partials ⚠️
internal/assertions/order.go 95.78% 2 Missing and 2 partials ⚠️
codegen/internal/generator/funcmaps/funcmaps.go 50.00% 1 Missing ⚠️
require/require_assertions.go 99.37% 0 Missing and 1 partial ⚠️
require/require_format.go 99.37% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   87.99%   88.63%   +0.63%     
==========================================
  Files          71       73       +2     
  Lines        9324     9979     +655     
==========================================
+ Hits         8205     8845     +640     
- Misses        945      958      +13     
- Partials      174      176       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredbi fredbi merged commit 6fd3bdf into go-openapi:master Jan 20, 2026
22 of 23 checks passed
@fredbi fredbi deleted the test/refact-test branch January 20, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant