Open
Conversation
This feature adds light and dark mode support with a toggle button as per Issue gjwgit#66. Details: - Integrated theme toggle in AppBar. - Updated circular timer with theme-aware colors. - Improved AppButton colors for visibility in Dark mode. - Fixed linting issues and strict TODO check for Makefile prep.
Owner
|
Works great. Best to keep each feature as a separate PR - this seems to imply that delete all is part of this PR? Need to resolve the conflicts before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dark Mode Implementation: Integrated
ThemeNotifier
and updated MaterialApp to support dynamic theme switching.
Theme Toggle: Added a functional toggle button in the main AppBar.
Widget Refactoring:
AppCircularCountDownTimer: Replaced hardcoded colors with theme-aware colors (background, ring, and text).
AppButton: Adjusted gradients and text colors for high visibility in Dark mode.